burkeen / pagedown

Automatically exported from code.google.com/p/pagedown
Other
0 stars 0 forks source link

Localization of the editor #6

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi,

I'm in the process of developing a website in french and I was wondering if you 
already thought of the Localization of the different parts of the editor ?

I'm willing to do the job if we can agree on the architecture behind the 
changes.

Thanks for the great work !

Original issue reported on code.google.com by krt...@gmail.com on 17 Sep 2011 at 10:42

GoogleCodeExporter commented 9 years ago
I cloned the repository and pushed my changes there. You can see the changes 
made here : http://code.google.com/r/krtek4-pagedown/

I'd be more than happy to work with you to include this upstream.

Original comment by krt...@gmail.com on 25 Sep 2011 at 9:38

GoogleCodeExporter commented 9 years ago
Sorry I haven't replied until now. Thanks a lot; I like it. I'd probably go for 
a slightly different approach, but for the most part, this is good stuff.

So don't feel you have done this in vain; this is certainly something that can 
be added when I find the time. Thanks so far!

Original comment by b...@stackoverflow.com on 7 Oct 2011 at 3:40

GoogleCodeExporter commented 9 years ago
Don't worry, I understand you want to do some changes before including this to 
pagedown.

If you need some help, feel free to ask.

Original comment by krt...@gmail.com on 7 Oct 2011 at 4:58

GoogleCodeExporter commented 9 years ago
Hey Gilles, it took a looooooooooong time, but I've finally pulled this in. I 
have tweaked it a bit so you can override strings on a case-by-case basis, e.g. 
if you don't want to translate the whole thing, but just replace one or two 
strings. I have also kept English as the default in the main file for backwards 
compatibility.

Thanks a lot for you work, and sorry it took ages :)

Original comment by b...@stackoverflow.com on 8 Oct 2012 at 10:21

GoogleCodeExporter commented 9 years ago
Oh, and in case you want to keep using your original version: There's a small 
typo in your code ("codexample" instead of "codeexample").

Original comment by b...@stackoverflow.com on 8 Oct 2012 at 10:25

GoogleCodeExporter commented 9 years ago
Thanks for mentioning the typo !

I'll probably use your new version, I'll like how you preserve the English as 
default !

Again, thanks for the work :) Keep going !

Original comment by krt...@gmail.com on 8 Oct 2012 at 10:29