burkeholland / nativescript-statusbar

A NativeScript plugin to change the style of the status bar. Currently ios only.
MIT License
32 stars 14 forks source link

NativeScript 4 #14

Open simonox opened 6 years ago

simonox commented 6 years ago

Are there any plans to upgrade this plugin to {N} 4? It is still using {N} 3.

    "peerDependencies":{
        "tns-core-modules": "^3.0.0 || ^3.0.0-rc.1"
    },

The plugin works perfectly with {N} 4. I have tested this in the playground: https://play.nativescript.org/?template=play-ng&id=hM2zxJ&v=8

simonox commented 6 years ago

In iOS it renders two StatusBars in my App on iOS after upgrading to {N} 4.0.1.

screen shot 2018-05-29 at 10 50 32

 <StatusBar barColor="#1A356D" ios:barStyle="dark"></StatusBar>
 <StackLayout>
    <page-router-outlet></page-router-outlet>
 </StackLayout>

It worked with {N} 3.x.

I can reproduce this issue in the playground.

etabakov commented 5 years ago

With this fix the plugin is now compatible with {N} 5.0