Open seahindeniz opened 1 year ago
I have no idea how this would be possible. Is this still an issue?
Well, I have disabled it of course but I can re-activate and observe it
That would be great. I'm actively using the extension, and I have not experienced that issue.
Just tried joining a meet and seems like the issue still persist 😞
I finally experienced the issue. Refreshing the page and rejoining the meeting always resolves it though. I'm still wondering if it's unrelated to my extension. I don't see how my extension could interfere with that. For me it only happens sometimes, and I don't need to disable or uninstall the extension to resolve it, so it's difficult to know what's actually causing the issue.
I see. Well, I have tried refreshing, reopening the page even in a new tab didn't worked. So the last resort was to disable it.
I'll try to debug it on my end, and see if I can find the root cause
Thank you, and I'm still investigating too. I really appreciate your time and effort on this.
I'm not sure, but when I added a timeout timer here, the issue is no longer persists. Maybe triggering the click event conflicts with Google Meet's framework, maybe the click listeners are mutating something where it actually depends on a state that may load after some application logic, maybe an internal ready-to-use state. I'm not talking about the DOM-ready, but it can be a Google Meet's framework issue. Having a little delay seems to sort this issue out, however, I'll be observing it for the next days
Nice! I'll give that a try too.
@seahindeniz How has it been with the delay?
So far no trouble at all. Works like a charm
Alright cool, I'll push a new update with the delay
I made some other changes. Would you mind pulling them and testing before I push the next update to everyone?
I pushed them to everyone.
Sorry for delaying, I was dealing with a time taking personal matter. I can pull and test it if you still need it
No worries! I was feeling confident it would work this time, so I decided to go for it. Yeah, that would be helpful. You can pull from the repo or use the one in the store. They are the same now.
I just joined to a meeting and the sound issue is still there 😔
I have reverted to the local version with the timer edit
So you chose to use the one on the store? Did it get updated to version 3.1.0 for you? If not, then it would definitely have the same issue.
Yeah, I currently have 3.0.0 the local version and 3.1.0 the store version. Enabling store version blocks audio completely. If I switch back to local version 3.0.0, working fine. However, when I enable it the first time yesterday, the local version was also interrupted audio too but when I rejoin the meeting again, issue got solved. I think it must be insufficient countdown that I added for 500ms
I added more of a delay into the repo version. Can you test again please?
Sure I can, on next Monday 😁
Some time ago, I noticed that Google Meet was not sounding other peoples voices. More specifically, when I test audio from the meet settings, the dummy song is getting played and I can hear the music. When someone speaks in the meet, I can see their avatar is getting blue highlight and blue pulse animation, but I can't hear peoples voices. When I disabled this extension, I could hear peoples voices again with no trouble.
I'm not sure if it's related to macOS update but, I have upgrade from Ventura to Sonoma and it might have an effect