search

burmanm / gorilla-tsc

Implementation of time series compression method from the Facebook's Gorilla paper
Apache License 2.0
210 stars 37 forks source link

Move benchmarks to test part #8

Open burmanm opened 7 years ago

burmanm commented 7 years ago

The Benchmark parts are still residing in the main/ section of the source code, while they should be in the test. This causes the jmh-libraries and all its subdependencies to flow to implementing programs.

marcin-sumologic commented 3 years ago

image

In short your library includes BenchmarkList file, if you include your project as a dependency in a JMH test it will break the JMH with error:

Exception in thread "main" java.lang.IllegalArgumentException: The length should be multiple of 8
        at org.openjdk.jmh.util.lines.Armor.decode(Armor.java:110)
        at org.openjdk.jmh.util.lines.TestLineReader.readArmoredString(TestLineReader.java:70)
        at org.openjdk.jmh.util.lines.TestLineReader.nextOptionalParamCollection(TestLineReader.java:184)
        at org.openjdk.jmh.runner.BenchmarkListEntry.<init>(BenchmarkListEntry.java:129)
        at org.openjdk.jmh.runner.BenchmarkList.find(BenchmarkList.java:135)
        at org.openjdk.jmh.runner.Runner.internalRun(Runner.java:260)
        at org.openjdk.jmh.runner.Runner.run(Runner.java:209)
        at org.openjdk.jmh.Main.main(Main.java:71)

at least when use use JMH 1.2x.

burmanm commented 3 years ago

This is probably something that has changed with the newer JMH versions. The BenchmarkList file is created by JMH.