burner-wallet / burner-wallet-2

A modular, extendable Burner Wallet
MIT License
87 stars 39 forks source link

Module not found #1

Open santisiri opened 4 years ago

santisiri commented 4 years ago

After installing dependencies on local-wallet with both npm and yarn I get this after yarn start:

Module not found: Can't resolve 'base64url' in '/Users/username/Ethereum/code/burner-wallet-2/plugins/src/legacy/ui'
dmihal commented 4 years ago

Hey @santisiri! The problem is that local-wallet depends on other packages in this repo.

You can run yarn run install-all in local-wallet to install all packages.

DavidBurela commented 4 years ago

@dmihal I think this has arisen as a new error again. Looking at the commit history, it seems that install-all was removed 2 months ago in this commit: https://github.com/burner-wallet/burner-wallet-2/commit/35d7c70ead2158239d9acf5122a2a9b6941faaeb

Steps: Cloned git repo in the root project folder I ran

yarn install
yarn run install
yarn run start-local

it errors when trying to compile the .tsx files

Cannot find module '@burner-wallet/ui-core'
Module not found: Can't resolve '@burner-wallet/legacy-plugin' in '/home/david/burner-wallet-2/local-wallet/src'
etc

running yarn run install-all in the /local-wallet folder, results in a command not found error (as it has been removed).

DavidBurela commented 4 years ago

Resolved it. You need to manually trigger yarn run build in the root directory. This will build all of the dependencies.

I created a PR for this https://github.com/burner-wallet/burner-wallet-2/pull/17