search

burner-wallet / burner-wallet-2

A modular, extendable Burner Wallet
MIT License
87 stars 36 forks source link

Consider switching to a monorepo #8

Closed PaulRBerg closed 4 years ago

PaulRBerg commented 5 years ago

I love this project, yet it's a bit counter-intuitive to have to install the dependencies of all plugins by going to "local-wallet" and running the "install-all" script. This is why Santiago opened #1.

Monorepos can enhance the dev ux a lot. Frameworks like yarn workspaces make it stupendously fast to manage a large number of dependencies across many packages. The trick is to cache the node modules at the root of the monorepo and, if there's a dependency with 2 or more versions, move them in their individual packages.

We use yarn workspaces at Sablier and it works great for us. Other projects like Truffle and Aragon use lerna to achieve the same goal.

dmihal commented 5 years ago

I've been working on turning the repo into a Lerna project, although I admit it's been low priority.

@PaulRBerg Any thoughts on Lerna vs yarn workspaces?

PaulRBerg commented 5 years ago

Yarn workspaces does wonders and you can use it without lerna.

(I'm not sure why we still have the lerna.json file in our repo. Haven't touched it in months)

dmihal commented 4 years ago

Project is fully using lerna & yarn workspaces, thanks @PaulRBerg!