search

burner-wallet / burner-wallet-2

A modular, extendable Burner Wallet
MIT License
88 stars 39 forks source link

Suggestion: remove "Advanced" button when web3 is injected #9

Open PaulRBerg opened 4 years ago

PaulRBerg commented 4 years ago

When I open the burner in a web3-less browser, the Advanced page shows three buttons: "Show PK", "Copy PK" and "Hide PK".

If I open the burner in a browser with MetaMask enabled, the same page shows up as empty.

Screen Shot 2019-09-28 at 20 01 22

Ideally, there would be no "Advanced" button when web3 is injected - and perhaps a hint that you should switch to "dai.poa.network" would help.

dmihal commented 4 years ago

The advance page will stay, as there may be more elements added to that page. However, the advance page should definitely explain that Metamask is being used, and the private key can not be used.

PaulRBerg commented 4 years ago

The advance page will stay, as there may be more elements added to that page

Makes sense!

Hope it helps.