search

burningmantech / ranger-clubhouse-web

Ranger Secret Clubhouse Web Application
Apache License 2.0
14 stars 10 forks source link

Submitted Ranger Access Docs fail to trigger the BMID Sanity Checker #260

Closed rangerthreepio closed 11 months ago

rangerthreepio commented 5 years ago

Submitted RADs do not appear in the BMID sanity checker, which is a problem since the sanity check is explicitly designed to be run in the period between the ticketing submission deadline and the event, to catch folks who sign up for shifts prior to their WAP date.

Conversely, the current sanity checker code displays all Rangers with a submitted WAP as having "no WAP" which is obviously ridiculous.

mikeburg commented 5 years ago

Another section needs to be added to flag those individuals who have submitted BMIDs yet have signed up for shifts before their access date.

techxorcist commented 2 years ago

3PO and Firecracker: Frankenstein's fix looks like a solid one IF it addresses both of the sub issues listed. FC and I have no additional input other than Frankie's suggestion looks good to us.

mikeburg commented 2 years ago

The checker will break out submitted WAPs versus qualified/claimed ones with access dates later than the first shift sign up. Please test!

rangerthreepio commented 2 years ago

Tested. New section works as intended with a caveat:

Unexpected issue: Once a WAP is submitted the conflict will remain in the checker, even if a new, earlier WAP is added (whether qualified or submitted). This means the checker will continue to flag the issue even after it is resolved.

This may be because the checker looks for ANY WAP dated after the first shift (even if the Ranger has more than one WAP), or it may be because the checker uses the BMID date.

The BMID date appears to pull from the first submitted WAP, so even if a second WAP is created and marked submitted, the BMID access date remains the same as the first submitted WAP and cannot be edited. This may be OK, or it may not be ok. I'm not sure what all issues it could cause to have the BMID date be superceded by an earlier WAP but not updated.

mikeburg commented 11 months ago

No reported problems. Closing out.