search

burningmantech / ranger-ims-mac

Ranger Incident Management System—Mac OS Client
Apache License 2.0
4 stars 2 forks source link

Autocomplete Doesn't Respect Capitalization #28

Closed wsanchez closed 9 years ago

wsanchez commented 10 years ago

I typed "Airport" as the name of a location. The first autocomplete suggestion was "a", which changed my capital A to a lower-case a. Ignoring the autocomplete suggestion, I typed "irport", which resulted in "airport" instead of "Airport."

Related: both "a" and "A" are in the autocomplete list; presumably we could end up with both "tokyo" and "Tokyo" (and "tOkYo"), which should probably all be grouped into a single case-insensitive entity.

wsanchez commented 10 years ago

This relates to burningmantech/ranger-ims-server#1, which would make locations first-class objects that you could edit centrally.

I guess in the meantime, it could make sense to de-duplicated case variant names, but then we’d also need logic to chose which one to use, and that may be the wrong one… really the fix is to edit the data to make them match, which is manual and annoying without burningmantech/ranger-ims-server#1. Dunno.

wsanchez commented 10 years ago

https://github.com/burningmantech/ranger-ims-mac/issues/28

wsanchez commented 10 years ago

Whoops

wsanchez commented 10 years ago

I think we need to add "whatever is being typed in" to the list of autocomplete options. That may solve a bunch of autocomplete complaints…

wsanchez commented 9 years ago

Still an issue in v3

wsanchez commented 9 years ago

OK so in https://github.com/burningmantech/ranger-ims-mac/commit/f9965834444231990a4f95cd692dc7078a38d5ed, we have two behaviors for autocompleting text fields:

Restricted Entry

For input fields where only known values are allowed, autocomplete will offer options if there are multiple, or simply complete the word if there is only one match.

For example, of the only two Rangers with handles starting with "E" were Easy E and El Weso, typing a "E" into the Rangers input field will show two options, and typing "Ea" will complete to "Easy E".

The "Restricted Entry" behavior applies to the Ranger, Incident Type, and Concentric Street Address input fields.

Unrestricted Entry

Location names don't currently autocomplete in v3 but when they do, you will be allowed to type anything into the field. In order to get a completion value, you have to choose it; at no point will it complete a word for you. This is done by putting whatever you have entered into the field in as the first option in the completions list, before all of the pre-existing location names.

This avoids the annoying behavior described in #20 and also respects case.

The "Unrestricted Entry" behavior will apply to the Location Name input field.

I'll leave this open until I add autocomplete into the location name field, so it can be verified.

wsanchez commented 9 years ago

Location names complete in https://github.com/burningmantech/ranger-ims-mac/commit/9e92e02b342711b6f4aafe6b797076bda0a3601a in the manner noted above.

wsanchez commented 9 years ago

Please verify with Incidents 3.0a1.