search

burningmantech / ranger-ims-server

Ranger Incident Management System—Server
Apache License 2.0
27 stars 7 forks source link

Use local jquery to avoid redirect issue #1165

Closed toddgardner closed 5 months ago

toddgardner commented 5 months ago

Fix for #1164

Fine with this not being accepted as people might not want to check in deps; but it does reduce network dependencies in the deprecated frontend.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 69.06%. Comparing base (efbe846) to head (abe61ef). Report is 5 commits behind head on master.

Files Patch % Lines
src/ims/application/_external.py 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1165 +/- ## ========================================== + Coverage 69.03% 69.06% +0.02% ========================================== Files 187 187 Lines 9051 9050 -1 Branches 1484 1484 ========================================== + Hits 6248 6250 +2 + Misses 2702 2700 -2 + Partials 101 100 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wsanchez commented 5 months ago

I'm trying to avoid venturing 3rd-party code here because it mixes up licensing. The network dependency is only on the first time the server starts up; at that point it serves a caches copy to clients.

chaoticbear commented 5 months ago

@toddgardner can you assign yourself to the issue for this? https://github.com/burningmantech/ranger-ims-server/issues/1164 Assuming you're going to keep working on it. If not no pressure. Just a nudge so we can all know what each other are working on and avoid overlap.

toddgardner commented 5 months ago

@toddgardner can you assign yourself to the issue for this? #1164 Assuming you're going to keep working on it. If not no pressure. Just a nudge so we can all know what each other are working on and avoid overlap.

I'm not sure if I can assign myself without being added to the repo

toddgardner commented 5 months ago

Closing this for something to avoid checking in jquery