burntblark / ngx-sails-socketio

An Angular module for connecting SailsJs backend through SocketIO.
MIT License
10 stars 10 forks source link

Implement SailsQuery object to represent BLUEPRINT methods #37

Open burntblark opened 6 years ago

burntblark commented 6 years ago

BLUEPRINT methods that are allowed through routes should be ready to use. https://sailsjs.com/documentation/concepts/blueprints/blueprint-routes

So I think using the same names https://sailsjs.com/documentation/reference/blueprint-api it would be nice Because as LIB is for Sails I think it should follow the same nomenclature.

I say this because there are some methods like SAVE https://github.com/burntblark/ngx-sails-socketio/blob/fcacfbd9ff5db34e34487a7af22ede2ad7fada5f/src/sails.query.ts#L43

REMOVE Which in the case I believe should be called destroy. Because the remove in BLUEPRINT is used for something else https://github.com/burntblark/ngx-sails-socketio/blob/fcacfbd9ff5db34e34487a7af22ede2ad7fada5f/src/sails.query.ts#L83

AND findById that does not meet any Waterline or blueprint nomenclature. https://github.com/burntblark/ngx-sails-socketio/blob/fcacfbd9ff5db34e34487a7af22ede2ad7fada5f/src/sails.query.ts#L33

Originally posted by @abalad in https://github.com/burntblark/ngx-sails-socketio/issues/35#issuecomment-437367239