burodepeper / language-markdown

Add support for Markdown to Atom (including Github flavored, Markdown Extra, CriticMark, YAML/TOML front-matter, and R Markdown), and smart behavior to lists.
https://atom.io/packages/language-markdown
MIT License
119 stars 295 forks source link

"add new list-items" creates multiple list-items in single row. #244

Open astrelochnik opened 5 years ago

astrelochnik commented 5 years ago

[Edited with picture] First time posting on Github, read the contribution guidelines, please go easy on me if I missed something.

I'm running Atom 1.34.0 on Arch/Gnome. My problem is that "add new list-items" will add two new list-items, or even more, if the list items are nested under other bullet points. Reloading atom does not fix the problem. even in safe mode. i.e. issue #129 does not solve my problem. To my knowledge, I have ensured any other packages that could potentially conflict are not doing so. for example:

multiplelistitems

you get the point. If I toggle the option off and then back on in language-markdown settings it results in four new list items for each row.

burodepeper commented 5 years ago

Thank you for reporting your issue! (The report is good)

I have not been able to reproduce your issue in either Atom 1.33.1 or 1.34.0 on macOS Mojave.

It's good that you've found #129. That was my first idea. It does seem related because the package seems to respond multiple times.

Do you have access to other machines/configurations that allows you to test if the problem persists?

astrelochnik commented 5 years ago

Using git I cloned my entire Atom configuration to a computer running Windows 10.0.17134/ Atom 1.34.0x64. Did the same with a Mac running Mojave 10.14.3/Atom 1.34.0x64. The problem does indeed persist on both machines.

I then did a fresh install of Atom with language-markdown as the only user installed package. The problem did NOT persist. So it appears it is a problem with my specific configuration, no? For the life of me I can't figure out what it is, because if I turn off "add list-items" in language-markdown Atom does not continue to auto add list-items. Alas, I'll keep looking and report back in case it is of any use to this project.

Thanks!

burodepeper commented 5 years ago

So it appears it is a problem with my specific configuration, no?

Considering the clones had the issue, I reckon, yes.

A clean install on your Arch/Gnome might fix your issue.

areographe commented 4 years ago

Hi, I'm using

Electron: 5.0.13
Chrome  : 73.0.3683.121
Node    : 12.0.0

on Manjaro Cinnamon and on macOS Sierra, with two different Atom user profiles with different plugins.

However, on both of them I have experienced this same bug, but after deactivating all other user-installed packages, I have found that this bug goes away, but now the list numbering doesn't start again at the new level when being indented. As in, it becomes:

1. testing
2. indent
    3. function
    4. results in this

Screencap here

Is this the intended behaviour? I was hoping that the numbering would restart for the next level.

burodepeper commented 4 years ago

I understand that this behavior feels weird, but the numbers in an ordered list should not affect the output after your Markdown is processed. It is not intended in this way, but rather a somewhat harmless effect of my naive implementation of this feature.

If this annoys you, you could consider disabling autoIncrementListItems in the settings.

areographe commented 4 years ago

Gotcha, that's fair enough. I guess I was just thinking in terms of maintaining readability in raw Markdown, it's good to have numbering consistent at each level of indentation, but I can easily just do that manually. I think I was also influenced by having used vim-pandoc and bullets.vim before switching to Atom, because they default to LibreOffice style 1, a, i / 2, b, ii behaviour, but I understand that's probably quite hard to implement, given that it doesn't affect processed output. Thanks for the excellent Atom package and keep up the good work!

burodepeper commented 4 years ago

You're welcome!

It would indeed be clearer to implement it as you suggest, and I think it wouldn't even be that difficult, but alas, I'm no longer actively maintaining this package. I've stopped using Atom no too long ago. It seems the development of Atom has slowed down significantly, and while I still think it's a great editor, I've personally switched to vscode as it better matches my needs.