One Dark UI not reading syntax-variables from theme on Ubuntu

[baurigae]

This is by far the best syntax highlighting package I've tried with markdown on Atom so far - naturally, I get greedy - so - any chance of a dark version?

:)

Either way, thanks for your effort!

[burodepeper]

Hi @baurigae, thank you very much, and as a matter of fact, I have been looking into making a dark version recently, but my attempts have been unsatisfactory as of yet. I'll give it another shot today, and will let you know if anything fruitful comes out of it.

[burodepeper]

Hi @baurigae, it is far from perfect, but I've published a minimal-syntax-dark theme. Let me know what you think of it, and whatever you think can improved upon. I'm open for all suggestions. I don't use dark themes myself, not often at least, and this first version needs a lot of little updates to get it up to par with the regular minimal-syntax. It uses yellow, pink and cyan as default colors, so it at least gives of a nice 80s vibe ; )

[baurigae]

I'll test is as soon as I can, and report if there's anything, thanks a lot!

[baurigae]

First of all I love the colors, they're perfect :) Now there are some issues, the One Dark UI theme is not picking up the bg color for the tabbar, tabs, etc, and then with the package typewriter (https://github.com/braver/typewriter) it looks like this:

For comparison with another syntax theme (again, with One Dark UI):

[burodepeper]

Ah yeah, I have never bothered to look into that, because it is not really an issue for light syntax themes. I hope to have an update ready for you before the end of the day (at least, my day).

[burodepeper]

Okay, I'm afraid I'm going to have to dig into it a little deeper and fix some structural things. You'll see the update come by automatically. Thanks for notifying me about this.

[burodepeper]

Et voila! Update and enjoy!

[baurigae]

I've updated but I see no change, still the same issue as in the first pic I posted.

[burodepeper]

Could you try quitting and restarting atom? I think the ui-theme doesn't update immediately after a syntax-theme has changed.

[burodepeper]

@baurigae I've looked into it a bit more, and in One Dark UI it should work, especially after restarting Atom. I have discovered what might be a bug related to either typewriter or ui-themes in general. So, I hope it at least works for you. If you ever run into it again, try reloading Atom by pressing Cmd + Alt + Ctrl + L; this seems to do the trick for me (most of the time).

[baurigae]

I tried reloading immediately, and now again.. sadly, no effect. Such a bummer, I love the colorscheme.. it doesn't just affect the typewriter, the tabbar and the tabs still fail to inherit the color from the theme even when that package is not used. I remember now seeing this problem in a couple of themes after Atom v.1 was released and before they updated.. but no idea what might have been causing it.

[burodepeper]

I assume you are using the latest version of Atom?

[baurigae]

Damn should have said that right away ) I'm running 1.0.19 I think that's the latest stable for Linux

[burodepeper]

That's the same version I am using. Hmmm... :( Okay, I know what is going wrong, I just don't know (yet) why. Would you be open to do a Skype (or similar) chat so I can view (via screen sharing) what's happening in your Atom (in the dev-tools)? If so, send me an email via my public email address. I need to figure this out : ) I'm starting to appreciate the dark-version now too, so I want it to be 'more perfect'.

[baurigae]

Hey @burodepeper and thanks for spending so much time on this, though I feel a little guilty now sidetracking you in this direction ) Well since I have no Skype on this Linux rig (conscious choice, long story..) I thought before I go to the trouble of installing it just for this problem, I'd test Atom & your syntax in a live Linux session - to completely rule out it's my setup on real hardware that's the problem. And in a live session, off an SD card - it all works perfectly. So it's my usecase in my setup on Ubuntu 15.04, and now I have a problem I must solve at any cost ) I won't let up until I figure out what in this setup messes up with your theme, and potentially, with a few others. But really and I mean it, my effort is about this theme. I love the hotpink in my css and must have it :) I think you have a great dark theme on your hands.

I'll report on any progress. Or you could just close this :)

[burodepeper]

Hey @baurigae, It is/was my pleasure to help, so no worries there. And too bad it is specifically because of your specific set up. Let me know when I can help you test anything. I'm keeping this issue open, but I'll change the title to something more specific, just in case you have an identical twin with the same problem.

If it helps in your quest, this is where I approximately think something goes wrong: https://github.com/atom/one-dark-ui/blob/master/styles/ui-variables.less#L6 The ui-theme looks for the background-color set by the syntax-theme. And for some reason, in your case, it thinks that value is white/wrong, ergo the ugliness.

Does it help btw if you disable the typewriter package?

[burodepeper]

PS, the hotpink indeed is great : )

[baurigae]

Yep, it's all kinds of perfect :) and of course change the title to anything that's useful to you in tracking your issues. Thanks for keeping it open, tho :)

And thanks for the tip & the link, I'll look into it with gusto (dammit I wish I didn't have a day job so I could spend more time on stuff like this...) And I'll report back if I make progress. Also since the dark theme itself works great (outside the UI elements..) if there's anything there, I'll report it over at the appropriate package.

Edit: oh damn.. no, disabling typewriter makes no difference.

[burodepeper]

I'll start working on a matching UI theme in the meantime... :)

[burodepeper]

How about this? Dark version coming soon...

[baurigae]

Looks great! Wow. Really looking forward to this!