disable repository search in parent directories

[pagran]

git is very smart and tries to find repository in parent directory. This is a very strange situation, but in our modinfo test, this is exactly what happens:

toor@root:/tmp/go-test-script3218627159/script-modinfo/.tmp/garble-shared3668927587/linker-src$ git log
commit 36f59e140927694cf85e88e1d4bf7440474f89c7 (HEAD -> master)
Author: name <name@email.local>
Date:   Wed Feb 8 00:38:26 2023 +0100

    very unique commit message

Fix prevents this behavior

[mvdan]

Please document in the code why we need to set the flag on top of the Dir field.

Also, are we actually sure that this will fix the bug? We already tried once and didn't get it :)

I first thought that writing a regression test would be good, to ensure the code works, but then again we'll stop using git apply hopefully sooner than later. So I don't think it's needed.

[pagran]

I can extend modinfo test with linker rebuild and additionally add a panic in case of a "silent" patch skip

[mvdan]

I don't think it's worth it to be honest. The test will be slow, it has nothing to do with module version info, and we'll stop relying on executing git soon. But we should manually verify that the bug is fixed.

[pagran]

But it makes sense to add an extra check in case of "silent" skipping patches

[mvdan]

Sure, why not. Perhaps you can do something like:

[!short] env OUR_LINKER_CACHE=/some/empty/dir

...

# ensure no panic
[!short] exec built-binary

You should verify this with master, but I think this would always trigger the failure, and it would keep go test -short as fast as before.

[mvdan]

Or, to keep the tests more on topic, we could instead make the linker.txtar test set up a git repo with one commit, and do the similar [!short] env OUR_LINKER_CACHE=/some/empty/dir line to always patch and build a new linker with go test, but not go test -short. I think I prefer it that way, to keep all the linker stuff under one test.

[pagran]

Without --git-dir flag:

--- FAIL: TestScript (0.17s)
    --- FAIL: TestScript/linker (3.53s)
        testscript.go:429: WORK=/tmp/go-test-script1447969318/script-linker
            > [!short] [exec:git] exec git init -q
            > [!short] [exec:git] env GARBLE_CACHE_DIR=$WORK/linker-cache
            > garble build
            [stderr]
            # test/main
            cannot get modified linker: expected 2 applied patches, actually 0:

            Skipped patch 'cmd/link/internal/ld/pcln.go'.
            Skipped patch 'cmd/link/internal/ld/pcln.go'.

            exit status 2
            [exit status 1]
            FAIL: testdata/script/linker.txtar:4: unexpected command failure

FAIL
exit status 1
FAIL    mvdan.cc/garble 3.720s