search

burtbeckwith / grails-nettymvc

10 stars 1 forks source link

Not currently working with 2.4.3 #1

Open orubel opened 10 years ago

orubel commented 10 years ago

commented out tomcat and added this. did a 'clean-all' and then run-app and got error. same with run-war.

error is as follows

No default container found. Please install a container plugin such as 'tomcat' first.

burtbeckwith commented 10 years ago

Have you been using this and it no longer works? Or are you just trying it now? After I got it working it didn't seem to be any more performant than using the regular servlet API, so I haven't followed up.

orubel commented 10 years ago

just tried it. if there's no real perfomance gain, no biggy :)

Owen Rubel 415-971-0976 orubel@gmail.com

On Mon, Sep 22, 2014 at 2:52 PM, Burt Beckwith notifications@github.com wrote:

Have you been using this and it no longer works? Or are you just trying it now? After I got it working it didn't seem to be any more performant than using the regular servlet API, so I haven't followed up.

— Reply to this email directly or view it on GitHub https://github.com/burtbeckwith/grails-nettymvc/issues/1#issuecomment-56449282 .

orubel commented 10 years ago

all performance gains will come with spring-boot and grails 3 :)

Owen Rubel 415-971-0976 orubel@gmail.com

On Mon, Sep 22, 2014 at 2:52 PM, Burt Beckwith notifications@github.com wrote:

Have you been using this and it no longer works? Or are you just trying it now? After I got it working it didn't seem to be any more performant than using the regular servlet API, so I haven't followed up.

— Reply to this email directly or view it on GitHub https://github.com/burtbeckwith/grails-nettymvc/issues/1#issuecomment-56449282 .

georges-hatem commented 10 years ago

Hello, I wasn't sure how to merge the files with my current Grails 2.4.3 app, then I came across this page. Do you mean that the plugin isn't providing additional performance on new versions of grails anymore? Thanks!

burtbeckwith commented 10 years ago

I only tried it with a couple of recent versions when I was developing it, and didn't see any speed improvement. So it's not worse, which is a good thing. I don't know if I did a fair test though - should compare IO-bound request handling to show that long-running requests don't affect short non-IO bound requests. But we'll be revisiting this as part of Grails 3, basing the core on Spring Boot, adding more Ratpack/Vertx/Node-style options for reactive/async, etc.

But if you find anything in this plugin that's misconfigured and affecting a performance boost let me know; it'd be good to have this as a viable option.

georges-hatem commented 10 years ago

okay will do, thanks :)