search

burtcorp / jmespath-java

A Java implementation of JMESPath
BSD 3-Clause "New" or "Revised" License
169 stars 39 forks source link

Add VertxRuntime #55

Closed ke4roh closed 5 years ago

ke4roh commented 5 years ago

Vert.X is a popular library supported by the Eclipse Foundation and used by quite a few big players. This is a Runtime to support jmespath in its flavor of JSON.

ke4roh commented 5 years ago

It looks like Travis is having trouble today.

ke4roh commented 5 years ago

@iconara, would you be one to review this for merging?

iconara commented 5 years ago

Hi @ke4roh, sorry for not noticing your PR, I've been on vacation. I'll have a look at it as soon as I can. Thanks for contributing!

ke4roh commented 5 years ago

Thank you for the thorough and detailed review. Every bit seems perfectly reasonable; the following commit attempts to capture it all. Let me know if it doesn't!

iconara commented 5 years ago

@ke4roh this is now merged and I've pushed another build of 0.3.1-SNAPSHOT. The actual release will have to wait, I'm still traveling and I don't want to get into releasing Maven artifacts while on the road, I realised. Probably Monday, hope that works.

iconara commented 5 years ago

Just pushed a proper release, and I figured this should be 0.4.0 and not 0.3.1 given that it adds a whole new runtime.