buruzaemon / natto

A Tasty Ruby Binding with MeCab
BSD 2-Clause "Simplified" License
143 stars 16 forks source link

Merge enum_parse method into parse #41

Open buruzaemon opened 9 years ago

buruzaemon commented 9 years ago

Rather than have 2 methods that are quite similar, merge enum_parse into parse.

Enumerator could be returned when a as_nodes keyword argument is true.

This would mean getting rid of the parse behavior when a block is passed in, but that bit actually materializes all node instances first anyhow, which is not very effective or efficient.

buruzaemon commented 9 years ago

Make sure to mark enum_parse as deprecated after the 1.0.0 release.

buruzaemon commented 9 years ago

Or... how about having 2 separate methods?