Fix deprecated warnings for CakePHP 3.7

burzum / cakephp-file-storage

Abstract file storage and upload plugin for CakePHP. Write to local disk, FTP, S3, Dropbox and more through a single interface. It's not just yet another uploader but a complete storage solution.

MIT License

197 stars 84 forks source link

Fix deprecated warnings for CakePHP 3.7 #187

Closed stripthis closed 5 years ago

stripthis commented 5 years ago

Fix deprecated warnings for CakePHP 3.7 and skip log setConfig in bootstrap to avoid error if already defined.

coveralls commented 5 years ago

Coverage decreased (-0.3%) to 36.717% when pulling 2b2f135306c8abbaa768cd9310fe52201a0bb9e6 on stripthis:2.0 into 2bda670e1ed52bcc62ad3cc489a90b7c428538e8 on burzum:2.0.

burzum commented 5 years ago

@ravage84 @stripthis I appreciate the PR but bumping it to 3.7 would require a new major release and not adding this to 2.x.

@stripthis can we change it so we have a conditional check and can support both version within the 2.x release?

ravage84 commented 5 years ago

@burzum I'm OK with it now. Can you have a look, please? //cc @liviascapin

burzum commented 5 years ago

Awesome job @ravage84, thank you!

Do you want to wait for a review from @liviascapin as well?