fix url generation in cake if hash is empty

burzum / cakephp-file-storage

Abstract file storage and upload plugin for CakePHP. Write to local disk, FTP, S3, Dropbox and more through a single interface. It's not just yet another uploader but a complete storage solution.

MIT License

197 stars 84 forks source link

fix url generation in cake if hash is empty #188

Closed skie closed 5 years ago

skie commented 5 years ago

Issue was caused duplicated dots before extension in case if version parameter is null.

coveralls commented 5 years ago

Coverage increased (+0.08%) to 36.796% when pulling 709582ffe7ef845272c3fc22a0ba16d04ad10fd7 on skie:2.0 into e566dd7bcc21367be79387d27fb5b71335284f92 on burzum:2.0.

burzum commented 5 years ago

@skie can you add a test? And rebase, so the CI error goes away. I'll merge it as soon as CI is green.

skie commented 5 years ago

Tests added. Everything is green!

burzum commented 5 years ago

@skie aswesome! Thank you! ❤️