search

bus-stop / x-terminal

An xterm based Atom plugin for providing terminals inside your Atom workspace.
https://atom.io/packages/x-terminal
Other
39 stars 9 forks source link

[fix] Move from document.registerElement to window.customElements.define #510

Closed Spiker985 closed 1 year ago

Spiker985 commented 1 year ago

Should fix #509

All tests passed, and project was linted before commit. image image

Spiker985 commented 1 year ago

@UziTech Would you mind looking at this? I would've pinged someone else, however, you did say that PRs were welcome 😅

UziTech commented 1 year ago

Looks like some tests are failing in ci. Once those are passing I can merge this.

Spiker985 commented 1 year ago

I'll take a look, but my current assumption is because the original specs were using the new <element> syntax, and are now using a function which performs a similar action - that the specs are now incompatible

Even though those specs were updated alongside the methods

Spiker985 commented 1 year ago

I'm actually going to rescind this PR for now