search

bus1 / dbus-broker

Linux D-Bus Message Broker
https://github.com/bus1/dbus-broker/wiki
Apache License 2.0
683 stars 81 forks source link

More disconnect logging #180

Closed teg closed 5 years ago

teg commented 5 years ago

Be more fine-grained about the protocol violations causing forcible disconnect.

This is on top of #178.

teg commented 5 years ago

Updated to keep driver_end_read() in driver.c. We still rely on messages being verified before being passed to the driver, but let's keep the helper around for documentation purposes.

dvdhrm commented 5 years ago

I cherry-picked the patches, as they no longer applied cleanly (and are mixed with other PRs). I also pushed 2 style-fixes on top. Lemme know if you have any comments on them.

Otherwise, looks all good! We lack some error-handling in the controller, but we do properly fold everything, so it's just not as fine-grained as the peer-error-handling. We should fix that some day..

Thanks!