search

bus1 / dbus-broker

Linux D-Bus Message Broker
https://github.com/bus1/dbus-broker/wiki
Apache License 2.0
667 stars 78 forks source link

build: require c-ini and c-shquote only when launcher is enabled #296

Closed jirutka closed 1 year ago

jirutka commented 2 years ago

These dependencies are used only in launcher.

dvdhrm commented 2 years ago

Is there a particular reason you want to guard those dependencies? We usually consider the c-util dependencies part of the project, so we don't guard their inclusion, but only their linkage into the binary.

Generally, in dbus-broker we try to avoid any conditional compilation and instead compile everything for better compile-coverage, less conditionals during compilation, better testing, and vastly reduced test-matrix. The selinux and audit dependencies are special, as we do not control the recursively included deps there. Furthermore, some distros do not even build those libraries, so we really have to guard them.

I am not strictly against the compile-guards, but just wonder what the reason for that is? Note that we are not aware of anyone building dbus-broker without the launcher, anyway (besides testing), so this would not have a real effect, anyway, right?

dvdhrm commented 1 year ago

Closing for now. If there are any further comments on my explanation, please feel free to resubmit this!