busachick / harviewer

Automatically exported from code.google.com/p/harviewer
0 stars 0 forks source link

blocked in between connect and wait #24

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Added blocked time for entries that have resolve and connect times

What is the expected output? What do you see instead?
I see a bar that includes times for resolve, connect, blocked, wait... in that 
order. Blocked should be first I think.

What version of the product are you using? On what operating system?
Latest har viewer

Some extra questions:

Do you assume that you can never have resolve/connect times and blocked in the 
same entry? And if so is that observed only if firefox/firebug ?

Please attach a HAR file that can be used to reproduce the problem.
Har file attached.

Original issue reported on code.google.com by phobouli...@gmail.com on 9 Sep 2010 at 10:35

Attachments:

GoogleCodeExporter commented 8 years ago
thank for your harview code.
I agree with phoboulinos, blocked should be first.
so I made source editing to place "blocked" at first.
but there was a problem on  "summary of request times" pie chart.
color mismatching occurred between legend and actual piechart.

please see attached file.
this is "HAR Log Examples" on harview download package which I made some change.
in the captured image, "DNS/SSL" is -19ms and it covers a half of parcharts! 
the green area should be "blocked" area.

my solution is...if there is a pie-chart data below zero, then set to zero so 
that calculated arc is not cover all previous chart area.

this is my code sniffet.

http://code.google.com/p/harviewer/source/browse/trunk/webapp/scripts/tabs/pageS
tats.js
--------------------------------------------------------  

line 469: for (var i=0; i<data.length; i++)
          {
            if(data[i].value<0) data[i].value=0; <== this is my code fix.
            var thisvalue = data[i].value / total;

            ctx.beginPath();
            ctx.moveTo(center[0], center[1]);
            ctx.arc(center[0], center[1], radius,
               Math.PI * (- 0.5 + 2 * sofar), // -0.5 sets set the start to be top
                Math.PI * (- 0.5 + 2 * (sofar + thisvalue)),
                false);

Original comment by mymins...@gmail.com on 27 Oct 2010 at 3:57

Attachments:

GoogleCodeExporter commented 8 years ago
Patch committed at R337

Honza

Original comment by odva...@gmail.com on 13 Jul 2011 at 3:25

GoogleCodeExporter commented 8 years ago
Will be in HAR Viewer 2.0.13

Honza

Original comment by odva...@gmail.com on 13 Jul 2011 at 3:27

GoogleCodeExporter commented 8 years ago
This issue has been fixed in HAR Viewer 2.0.13

Please let me know if it works for you.

Honza

Original comment by odva...@gmail.com on 24 Jul 2011 at 7:21

GoogleCodeExporter commented 8 years ago
Yeap I tested this. Works fine. Nice!

Original comment by phobouli...@gmail.com on 8 Aug 2011 at 8:38

GoogleCodeExporter commented 8 years ago
Thanks for verification!
Honza

Original comment by odva...@gmail.com on 8 Aug 2011 at 10:19