Patch: Sprite the expand/collapse icon

[GoogleCodeExporter]

Here's a patch to use a sprite for the +/- image.  I'm not sure if the 
twisty-sprite.png image is used anywhere else, but I had to modify it so that 
it would work in this scenario.

--- webapp/css/requestList.css  (revision 296)
+++ webapp/css/requestList.css  (working copy)
@@ -377,11 +377,12 @@
 /*************************************************************************************************/

 .isExpandable .netHrefLabel {
-    background-image: url(images/twistyClosed.png);
+    background-image: url(images/twisty-sprites.png);
     background-repeat: no-repeat;
-    background-position: 2px 2px;
+    background-position: 3px 3px;
 }

 .netRow.opened > .netCol > .netHrefLabel {
-    background-image: url(images/twistyOpen.png);
+    background-image: url(images/twisty-sprites.png);
+    background-position: 3px -16px;
 }

Original issue reported on code.google.com by adrian...@gmail.com on 3 Jun 2011 at 11:36

Attachments:

• twisty-sprites.png

[GoogleCodeExporter]

Oops, forgot about the other uses of the icon:

Index: webapp/css/domTree.css
===================================================================
--- webapp/css/domTree.css  (revision 296)
+++ webapp/css/domTree.css  (working copy)
@@ -26,7 +26,8 @@
 }

 .memberRow.hasChildren.opened > .memberLabelCell > .memberLabel {
-    background-image: url(images/twistyOpen.png);
+    background-image: url(images/twisty-sprites.png);
+    background-position: 3px -16px;
 }

 .memberRow.hasChildren > .memberLabelCell > .memberLabel:hover {
@@ -36,11 +37,7 @@
 }

 .memberRow.hasChildren > .memberLabelCell > .memberLabel {
-    background-image: url(images/twistyClosed.png);
+    background-image: url(images/twisty-sprites.png);
     background-repeat: no-repeat;
-    background-position: 2px 3px;
+    background-position: 3px 3px;
 }
-
-.memberRow.hasChildren > .memberLabelCell > .memberLabel {
-    background-position: 2px 2px;
-}
Index: webapp/css/pageList.css
===================================================================
--- webapp/css/pageList.css (revision 296)
+++ webapp/css/pageList.css (working copy)
@@ -26,13 +26,14 @@
 }

 .opened > .pageCol > .pageName {
-    background-image: url(images/twistyOpen.png);
+    background-image: url(images/twisty-sprites.png);
+    background-position: 3px -17px;
 }

 .pageName {
-    background-image: url(images/twistyClosed.png);
+    background-image: url(images/twisty-sprites.png);
     background-repeat: no-repeat;
-    background-position: 2px 1px;
+    background-position: 3px 2px;
     padding-left: 18px;
     font-weight: bold;
     cursor:pointer;
Index: webapp/css/requestList.css
===================================================================
--- webapp/css/requestList.css  (revision 296)
+++ webapp/css/requestList.css  (working copy)
@@ -377,11 +377,12 @@
 /*************************************************************************************************/

 .isExpandable .netHrefLabel {
-    background-image: url(images/twistyClosed.png);
+    background-image: url(images/twisty-sprites.png);
     background-repeat: no-repeat;
-    background-position: 2px 2px;
+    background-position: 3px 3px;
 }

 .netRow.opened > .netCol > .netHrefLabel {
-    background-image: url(images/twistyOpen.png);
+    background-image: url(images/twisty-sprites.png);
+    background-position: 3px -16px;
 }

Original comment by adrian...@gmail.com on 3 Jun 2011 at 11:47

[GoogleCodeExporter]

Also, looks good, the patch committed at R299

Thanks!
Honza

Original comment by odva...@gmail.com on 4 Jun 2011 at 11:47

• Changed state: Commit

[GoogleCodeExporter]

This issue is one of 6 fixed in HAR Viewer 2.0.11
You can check it online here:
http://www.softwareishard.com/har/viewer/

Or download a distribution package from here:
http://code.google.com/p/harviewer/downloads/list

Read release notes here:
http://code.google.com/p/harviewer/wiki/ReleaseNotes

Honza

Original comment by odva...@gmail.com on 16 Jun 2011 at 4:14

• Changed state: Fixed

[GoogleCodeExporter]

This issue is one of 6 fixed in HAR Viewer 2.0.11
You can check it online here:
http://www.softwareishard.com/har/viewer/

Or download a distribution package from here:
http://code.google.com/p/harviewer/downloads/list

Read release notes here:
http://code.google.com/p/harviewer/wiki/ReleaseNotes

Honza

Original comment by odva...@gmail.com on 16 Jun 2011 at 4:14

[GoogleCodeExporter]

This issue is one of 6 fixed in HAR Viewer 2.0.11
You can check it online here:
http://www.softwareishard.com/har/viewer/

Or download a distribution package from here:
http://code.google.com/p/harviewer/downloads/list

Read release notes here:
http://code.google.com/p/harviewer/wiki/ReleaseNotes

Honza

Original comment by odva...@gmail.com on 16 Jun 2011 at 4:14

• Changed state: Fixed