[Bug]: key.split is not a function

lost-hope commented 3 months ago

Contact Details

s.willrodt@yahoo.de

Foundry VTT version

11.315

Game system

dnd5e

Game system version

3.0.4

actor-export module version

2024.5.3

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

What Provider is affected?

Dungeons & Dragons 5th edition Character sheets

What happened?

when trying to export i get a message that "key.split" is not a function.

Relevant log output

Foundry VTT | Rendering actorExportDialog foundry.js:5802:15
Please wait, this may take a while... foundry.js:68326:78
actor-export | provider: dnd5e main.js:42:25
actor-export | actor: 
Object { name: "Topaz", type: "character", img: "tokenizer/pc-images/topaz.Avatar.webp?1698534590395", system: {…}, prototypeToken: {…}, sort: 6000000, ownership: {…}, flags: {…}, _stats: {…}, overrides: {…}, … }
main.js:42:25
actor-export | character: 
Object { game: {…}, actor: {…}, className: "dnd5eActor" }
DND5eHelper.js:21:17
actor-export | An error ocurred executing the 'dnd5e' provider: key.split is not a function foundry.js:68326:78
Uncaught (in promise) Error: TypeError: key.split is not a function
[Detected 1 package: actor-export]
    downloadFiles http://v2202109156138162946.hotsrv.de:30000/modules/actor-export/scripts/main.js:471
    promise callback*downloadFiles http://v2202109156138162946.hotsrv.de:30000/modules/actor-export/scripts/main.js:464
    activateListeners http://v2202109156138162946.hotsrv.de:30000/modules/actor-export/scripts/main.js:318
    activateListeners http://v2202109156138162946.hotsrv.de:30000/modules/actor-export/scripts/main.js:316
    _render http://v2202109156138162946.hotsrv.de:30000/scripts/foundry.js:5842
    _render http://v2202109156138162946.hotsrv.de:30000/scripts/foundry.js:6532
    render http://v2202109156138162946.hotsrv.de:30000/scripts/foundry.js:5769
    onclick http://v2202109156138162946.hotsrv.de:30000/modules/actor-export/scripts/main.js:615
    _renderOuter http://v2202109156138162946.hotsrv.de:30000/scripts/foundry.js:5941
    jQuery 2
main.js:471:31
    downloadFiles http://v2202109156138162946.hotsrv.de:30000/modules/actor-export/scripts/main.js:471
    (Async: promise callback)
    downloadFiles http://v2202109156138162946.hotsrv.de:30000/modules/actor-export/scripts/main.js:464
    activateListeners http://v2202109156138162946.hotsrv.de:30000/modules/actor-export/scripts/main.js:318
    (Async: EventListener.handleEvent)
    activateListeners http://v2202109156138162946.hotsrv.de:30000/modules/actor-export/scripts/main.js:316
    _render http://v2202109156138162946.hotsrv.de:30000/scripts/foundry.js:5842
    AsyncFunctionNext self-hosted:852
    (Async: async)
    _render http://v2202109156138162946.hotsrv.de:30000/scripts/foundry.js:6532
    render http://v2202109156138162946.hotsrv.de:30000/scripts/foundry.js:5769
    onclick http://v2202109156138162946.hotsrv.de:30000/modules/actor-export/scripts/main.js:615
    _renderOuter http://v2202109156138162946.hotsrv.de:30000/scripts/foundry.js:5941
    jQuery 2
        dispatch
        handle
Foundry VTT | Rendering ModuleManagement foundry.js:5802:15
Foundry VTT | Retrieved and compiled template templates/setup/parts/package-tags.hbs foundry.js:7682:17
Foundry VTT | Retrieved and compiled template templates/sidebar/apps/module-management.html foundry.js:7682:17

Sample Actor

No response

Attachments

No response

bushvin commented 3 months ago

Would it be possible to get an export of your character?

lost-hope commented 3 months ago

~~sure if you tell me how to export it correctly~~

~~if i try to copy the part from the web dev console, i only get part of it~~ right click on the actor sheet, if future people stumble over this

lost-hope commented 3 months ago

fvtt-Actor-topaz-Yzg4YmY5Yjk5MWU0.json nvm found it

bushvin commented 3 months ago

Thank you! I am without pc today, so I will check tomorrow.

bushvin commented 3 months ago

Hello @lost-hope ,

I believe I have found the issue, and resolved it with the 2024.5.4 release.

If you have any recommendations wrt my module, feel free to let me know!

lost-hope commented 3 months ago

Hello,

Yeah it seems fixed now.

Just two other issues:

The detail sheet shows the GM notes

And the prepared spells are not correct

Here are the screenshots of the char sheet:

bushvin commented 3 months ago

Hey @lost-hope Apologies for my tardiness...

**Secret GM info** I see what you mean with the secret GM info*. I will need to see what I can do about that, as it is basically markup inside the actor's biography entry.

I imagine this is text you have added as a section or so to the biography, and I hope everybody using the DnD5e system does it the same way... Not pointing at you, pointing at the D&D5e System devs. This is IMO bad design.

Prepared Spells Should be an easy fix, I believe all check boxes are one too low.

bushvin commented 3 months ago

The issues above should be fixed as well with 2024.5.5

bushvin commented 3 months ago

FYI: I also have the german charactersheet now.

bushvin / actor-export