business-science / anomalize

Tidy anomaly detection
https://business-science.github.io/anomalize/
338 stars 60 forks source link

Add support for na.rm in 'gesd' method. #50

Open zschuster opened 4 years ago

zschuster commented 4 years ago

I was not able to execute anomalize::anomalize with method='gesd' if many NA values were present. This solves that problem by using the na.rm functionality within base R.

zschuster commented 4 years ago

The failed tests do not seem relevant to the changes I'm suggesting. Can you provide any explanation for this?

mdancho84 commented 4 years ago

Likely dplyr v1.0.0 compatability with tibbletime. https://github.com/business-science/tibbletime/issues/91