search

business-science / gammodels

The parsnip backend for GAM Models.
https://business-science.github.io/gammodels/
Other
7 stars 3 forks source link

function name #7

Open topepo opened 3 years ago

topepo commented 3 years ago

gam_mod() is a little short (and redundant). Maybe generalized_additive_mod() or general_additive_mod()?

mdancho84 commented 3 years ago

We can do it. Let me think about which one to go with, but yes I agree that the name should be much more descriptive.

mdancho84 commented 3 years ago

What about additive_model() as the general specification and then gam as the engine?

mdancho84 commented 3 years ago

I'm testing a few out. What about gen_additive_mod()? Still keeps things concise without being redundant.

mdancho84 commented 3 years ago

Hey, I refactored to gen_additive_mod(). Give it a look over and see if you like it.

If not, my next pick would be general_additive_mod() since it's only slightly longer.