search

business-science / gammodels

The parsnip backend for GAM Models.
https://business-science.github.io/gammodels/
Other
7 stars 3 forks source link

model definition location #8

Open topepo opened 3 years ago

topepo commented 3 years ago

If you think that other packages might have engine definitions for gam_mod(), it would make sense to have the definition for that model live in parsnip and have the engines registered here.

mdancho84 commented 3 years ago

I agree - what do you think: if we first get the package up and running as 0.1.0, and then in version 0.2.0 we transition the definition to parsnip and retain the engines? Just thinking about a good transition plan that doesn't slow down the development.

topepo commented 3 years ago

I would do it before it goes to CRAN. We'd have to soft-deprecate the old version and it would just be easier to move it before it is "official"

mdancho84 commented 3 years ago

Hey @topepo We are back on gammodels (yes, we had one more name change). We'd like to begin the process of preparing the package for integration with parsnip. We can finalize the package on our end, but it sounds like you'd like the main gen_additive_mod() function to rest in parnsip. What's the best way to get started there?