search

business-science / modeltime

Modeltime unlocks time series forecast models and machine learning in one framework
https://business-science.github.io/modeltime/
Other
522 stars 79 forks source link

Add recipe name to model name in modeltime table #115

Open spsanderson opened 3 years ago

spsanderson commented 3 years ago

When using the workflowsets workflow, I think it would be helpful to auto add the recipe spec name to the model name like occurrs in sknifedatar

Not sure how much work this would be.

https://rafzamb.github.io/sknifedatar/articles/workflowsets_times.html#workflowsets-1

mdancho84 commented 3 years ago

Will take a look. I believe other users have requested this. I need to check how nicely it plays with the modeltime workflow.

AlbertoAlmuinha commented 3 years ago

This is a must in my opinion @mdancho84 . Really I don't know when to tackle this but we have to do it, it's really difficult to track your combinations if the names are not set properly. I had a hard time with this writing my last post.

spsanderson commented 3 years ago

I will do my best to try to get something of this working and paste my code as a comment even if it is just a skeleton

mdancho84 commented 3 years ago

We can take a look at it. I don't know the downstream implications. My preference is to add an additional column with the additional model details that can contain the workflow set id. I don't like the idea of changing how the .model_id works because it's overwritten in many situations like if you combine a modeltime table with another using combine_modeltime_tables(). But I'm not opposed to adding the workflowset id for tracking.

AlbertoAlmuinha commented 3 years ago

I would not change the ID column either, as you say it is an important column and also involves changing the numeric type to string, so it does involve major changes, I would discard it.

For me another option would be to modify the .model_desc column and not add any additional column, we can see it.

mdancho84 commented 3 years ago

That sounds like a much better option. The Model Description will be overwritten during refitting, but we can add logic to manage this.

AlbertoAlmuinha commented 3 years ago

Do you think this format would be OK?

img

mdancho84 commented 3 years ago

That looks good.

spsanderson commented 3 years ago

@AlbertoAlmuinha that would be awesome! Then you know which recipe_model combo is the winner without having to lookup the model id and trying to figure out which recipe went with the model, I know I routinely use 5-6 different recipe_specs when I am looking at stuff

AlbertoAlmuinha commented 3 years ago

Can we close this issue yet guys? @spsanderson @mdancho84

spsanderson commented 3 years ago

This should also work with panel data correct? Meaning it would play nice with panel date as well?

Sent from my iPhone www.spsanderson.com

On Aug 9, 2021, at 2:57 PM, Alberto González Almuiña @.***> wrote:

 Can we close this issue yet guys? @spsanderson @mdancho84

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

mdancho84 commented 3 years ago

Yes. Panel data is covered.