search

business-science / tidyquant

Bringing financial analysis to the tidyverse
https://business-science.github.io/tidyquant/
Other
852 stars 175 forks source link

Remove ggplot2 aes warnings #242

Closed olivroy closed 9 months ago

olivroy commented 9 months ago

Fix #235.

Approach:

look at whatever compute groups return, and add anything else to dropped aesthetics.

I also changed the limits since the current limits show an empty plot. https://business-science.github.io/tidyquant/reference/geom_bbands.html#ref-examples

olivroy commented 9 months ago

@mdancho84 , whenever you have time, you can merge the 2 pull requests, as it solves errors !