Add auto cleanup for dump sql temp files

businho / django-migrations-ci

Cached migrations on CI (and local) for faster migrations

MIT License

28 stars 7 forks source link

Closed oruehenbeck closed 3 months ago

oruehenbeck commented 4 months ago

Hi,

would be nice to cleanup the temporary sql dump files.

I would suggest using the NamedTemporaryFile context manager, see the commit in this PR.

Would do you think about this small improvement?

iurisilvio commented 3 months ago

Thanks! At first I decided to not cleanup because filesystem will clean them eventually, but it is better to remove them.