search

buskerudbyen / cycling-norway

3 stars 2 forks source link

Bikely: The icon disappears after zoom levels 11 and up (zooming down) in Drammen city center #107

Closed tsobuskerudbyen closed 7 months ago

tsobuskerudbyen commented 8 months ago

Tested on Chrome and Edge om Windows. Same issue. Seems to be a bit on and off. Can you please check if you can reproduce @Beck-berry ?

image

leonardehrenfried commented 8 months ago

image

I can reproduce it in Chrome. Weirdly it works in Firefox, which is unusual because there stuff usually breaks.

@Beck-berry Can you take a look?

Beck-berry commented 8 months ago

For me, they are visible both on Firefox and Chromium 9-22 zoom levels. (I use Linux Mint 20.3 Una - Ubuntu). Also on mobile (Android, Chrome). I'll check this another time and on other environments too.

Beck-berry commented 8 months ago

On Windows 10, Chrome, the icon is visible at 9-16 zoom levels, then disappears.

tsobuskerudbyen commented 8 months ago

Strange stuff! Can something be done about it?

Beck-berry commented 7 months ago

I notoriously refreshed the site both on Chromium and Firefox, dropped the cache multiple times, and it seemed to solve the problem, however the browsers would never show the same result. (Same icons at the same places on the same zoom levels.)

I also downloaded the Bikely App to check the locations and there should be more than it is visible on sykkelveier.no.

I think something's up with the backend, some pbfs from byvekstavtale.leonard.io/vectortiles/bikely are not always available and I believe that this causes the icons to appear and disappear almost randomly. @leonardehrenfried could you check this issue? (Seems to be a CORS issue?)

Maybe connected with #100?

leonardehrenfried commented 7 months ago

I'm investigating this right now and I can confirm that it's because of the backend but I haven't actually figured out what exactly the problem is.

leonardehrenfried commented 7 months ago

I think I isolated the problem and it was unfortunately deep inside the guts of OTP. I've deployed a fix and will monitor the situation.

Would be great if you could provide a bit of feedback if you feel like the situation has improved.

leonardehrenfried commented 7 months ago

I don't experience any strange problems anymore so I believe that my fix was correct.

@Beck-berry @tsobuskerudbyen If you see this problem coming back, please re-open.

Beck-berry commented 7 months ago

I can confirm: seems to be OK on Chromium and Firefox.