Rephrase "Bikely parkering" to something more generic

buskerudbyen / cycling-norway

3 stars 2 forks source link

Rephrase "Bikely parkering" to something more generic #120

Closed leonardehrenfried closed 2 months ago

leonardehrenfried commented 4 months ago

I've added Bikeep realtime parking information today however, the legend still talks about "Bikely parkering".

@tsobuskerudbyen Can you come up with a more generic label?

tsobuskerudbyen commented 4 months ago

Documented here. https://github.com/buskerudbyen/cycling-norway/issues/102#issuecomment-2015081492

We need to discuss the number of items in the legend later. For now Bikeep should be seprate from Bikely.

tsobuskerudbyen commented 3 months ago

@leonardehrenfried: Can you look at this one or assign to Beck-berry?

leonardehrenfried commented 3 months ago

@Beck-berry can you please take care of it?

Beck-berry commented 3 months ago

We can create a switch in the legend for separate layers only. Since @tsobuskerudbyen wants Bikeep and Bikely to be separate, is there a way to add them as seperate layers, @leonardehrenfried? Do I understand right, you added the Bikeep data to the byvekstavtale.leonard.io/tiles/bikely.json file? Shouldn't be there a bikeep.json? That way I could add a different icon and switch to the legend.

leonardehrenfried commented 2 months ago

At the moment, this is not possible. I will need to configure that.

Putting that on my todo list.

leonardehrenfried commented 2 months ago

@Beck-berry here are the two tilejson files:

Beck-berry commented 2 months ago

@leonardehrenfried I changed the bikely source and added the bikeep layer (you can check the connected commit) but somehow they do not appear, however both requests got an OK response. Do you have an idea what's wrong? I'll keep investigating on this otherwise.

leonardehrenfried commented 2 months ago

I think I know what the problem is and I'm taking a look today.

leonardehrenfried commented 2 months ago

I have now fixed both the backend and the frontend and Bikeep and Bikely show up as different layers.

In Sandvika you can see both on the same screen: https://sykkelveier.no/?layers=anlegg%2Crute-nb%2Crute-lb%2Crute-no%2Crute-lo%2Cpoffentlig%2Cpprivat%2Cpskap%2Cphotell%2Cptak%2Crep%2Cbr%C3%B8yting-ok%2Cbr%C3%B8yting-senere%2Csn%C3%B8r%2Cpumpe%2Cbutikk%2Cpumptrack%2Cloype%2Cbikely%2Cbikeep%2Clavhastighet#13.36/59.89325/10.53658

I would suggest to close this ticket and @tsobuskerudbyen and @Beck-berry can work on the fine-tuning of the look and feel over at #102.