buskerudbyen / cycling-norway

3 stars 2 forks source link

Enhance display of elevation data #92

Closed Beck-berry closed 8 months ago

Beck-berry commented 10 months ago

Intro

Further development of #38. Current state as in #68.

Task

The elevation profile should be displayed when a route is planned. Something like: image

Questions

Since it could take up a lot of space, my goal would be to show the graph on some action. Eg. click some button, hover over the already existing icon... @tsobuskerudbyen What would you prefer? Do you have other ideas?

tsobuskerudbyen commented 10 months ago

I like the idea of having the option to look at it. Can you try hover over the elevation meter information?

Beck-berry commented 9 months ago

Image

@tsobuskerudbyen What do you think in general?

Additional questions: Would you like to keep the title? If so, please give a proper translation. Should we change the color? This blue is the default, like the color of the buttons. Also, I think the hover action won't be enough, the users won't know about this feature until "accidentally" hover over the elevation meter information. (And on mobile it definitely should be clicked.) Should we make that a bit more button-like somehow? Or add another link/button to the side panel which can control the modal?

leonardehrenfried commented 9 months ago

I will let @tsobuskerudbyen make the decisions but I just wanted to say that it looks really nice.

Would it be possible to condense some of the points?

Beck-berry commented 9 months ago

@leonardehrenfried You meant something like this?

Image

I removed the point representation of each elevation number.

leonardehrenfried commented 9 months ago

Yes, this looks great!

tsobuskerudbyen commented 8 months ago

Great stuff this. Swamped with other work. Sorry for the delay in answering.

Would you like to keep the title? If so, please give a proper translation.

Yes, keep it please: "Høydeprofil (meter)"

Should we change the color? This blue is the default, like the color of the buttons.

Blue is fine. Would it be possible to change the top line of the graph to the same colour as the route suggestion line that is in the map?

Also, I think the hover action won't be enough, the users won't know about this feature until "accidentally" hover over the elevation meter information. (And on mobile it definitely should be clicked.) Should we make that a bit more button-like somehow?

Good idea. How about making a boxed background of the elevation info of the route with the same colour as the other buttons? (And then change the numer to white as well.)

Or add another link/button to the side panel which can control the modal?

Unsure about this. For example: Can it, on larger screens, be added to the "tegnforklaring" list, and automatically be visible under this part of the screen? If this is hard, just leave it for now.

Beck-berry commented 8 months ago

What do you think?

Image

tsobuskerudbyen commented 8 months ago

Good stuff! Go for it. :)

leonardehrenfried commented 8 months ago

This is now deployed to sykkelveier.no.