buskerudbyen / cycling-norway

3 stars 2 forks source link

More cycle route Information visible in the map #97

Closed tsobuskerudbyen closed 4 months ago

tsobuskerudbyen commented 8 months ago

Is it possible to add some more basic cycle route information details? On click? But, when more than one route on a road what then?

  1. Start with the description tag.
  2. Change the language if there are other present. Possible?
  3. Pictures? Is it possible? Where and how?

Example: https://www.openstreetmap.org/relation/11921767

tsobuskerudbyen commented 6 months ago

@leonardehrenfried: Can you please comment on this one?

leonardehrenfried commented 6 months ago

1 and 2 will be possible by putting the information in a popup. We already do something very similar for the opening hours of tunnels.

3 will be quite impossible, at least until there is a good data source to get photos for an OSM relation.

tsobuskerudbyen commented 6 months ago

Great. Can some initial work be done here then? Look into how it is displayed for example.

leonardehrenfried commented 6 months ago

@Beck-berry can take this on

Beck-berry commented 6 months ago

I created a demo. Right now the popup opens on the click on the name of the route, since it's visible. The popup displays the name, the from - to and the description tags.

Image

Sadly, the other routes in Drammen do not have any information other than the names. Question is, do you want to display any popup if there is no description for the relation? What languages should we display? Sølvveien has German name and description and English name, thus the content would differ per language.

I have an idea for multiple routes: on the click on the road, a selector panel should appear in the popup. Eg. three rows for "Sølvveien", "Åssiden" and "Bragernes torg - Vinnes" relations where they have a common part (eg. Ovre Torggate). The user then can select one and if the route has some detailed data, it would appear as above; otherwise we could display a common text with the OSM URL to encourage the user to add a description(?) or any other common text you'd like. @tsobuskerudbyen What do you think?

tsobuskerudbyen commented 5 months ago

Sorry. Overlooked this one. Looks good, and I like your suggestion. But, what if you want a destination or start location close to the route. Will it be confusing, or even cause irritation, that the route information pops up?

Beck-berry commented 5 months ago

That should be really close 😄 And if so, this problem would occur with any other popup. Do you know about that, is it irritating? (I don't know how and how many reactions / bug reports / comments you get.)

tsobuskerudbyen commented 5 months ago

Cool. :) No feedback from users so far (it is a bit hard to find the e-mail perhaps), and only some feedback from people I cooperate with. Other than questions for functionality. This ticket is an example from Vestfold County and a cycle route to the End of the World (!). Another example is the colour one (#109). From Gjøvik municipality.

Beck-berry commented 5 months ago

When multiple routes found: Image

When there are no description / from / to information: Image

@tsobuskerudbyen How do you like it? Any ideas are welcome!

I recommend deploying it without the language change at first, maybe you'll get more feedback on it! :) (Eg. what languages should we display; what to display when there are not enough information in OSM.)

tsobuskerudbyen commented 5 months ago

Looks good. Is it possible to prioritize the order and the routes visible - or even enabled - in selection box UI? So, if no further description is available, they can be put on the bottom and greyed out (so not possible to click on it) and then, in your example, it is only "Sølvveien" that is on top and enabled.

Norwegian translation: "Flere sykkelruter funnet. Vennligst velg:". If too long. Try: "Velg én av flere sykkelruter:"

Move out to a new ticket if needed

1] Type of route Also, in the selection box, please add:

2] Website link Can we add to the main information window:

Example of a good one: https://www.openstreetmap.org/relation/1213626

Beck-berry commented 5 months ago

@tsobuskerudbyen What do you think?

Image

Image

Image

Image

tsobuskerudbyen commented 4 months ago

Look perfect. Good work!

Beck-berry commented 4 months ago

Please create a new ticket if you have requests for the multi-language feature. I'll deploy this as it is today.