search

buster / rrun

minimalistic command launcher in rust
GNU General Public License v2.0
112 stars 14 forks source link

Replace hard-coded UI by Glade designed XML #18

Closed nightscape closed 8 years ago

nightscape commented 8 years ago

This should make implementing #12 much easier :) No changes to the UI yet. Is the search_entry feature distinction important? If so, I can change the Glade file not to include the Entry/SearchEntry widget and add it from the code (as it was before).

buster commented 8 years ago

The distinction was just made, because travis uses some ancient Ubuntu with an older GTK version. I like the look of the SearchEntry more then a plain Entry field. But i would be fine without SearchEntry. Glade powered UI is far nice then that!

buster commented 8 years ago

As you can see, the build failed, because it can't find SearchEntry on the Ubuntu that travis is using..

nightscape commented 8 years ago

Ok, just restored the feature-scoped functions and amended to the commit.

buster commented 8 years ago

That's frustrating. It looks like travis has gtk 3.4? But Builder::new_from_string is from 3.10.

There is also a new way to use travis with containers, but i haven't got it to work wither (i think some libraries were missing the last time i tried)...

Apart from that.. any ideas?

buster commented 8 years ago

The travis ticket for an Ubuntu update has not seen updates sind 2014.. https://github.com/travis-ci/travis-ci/issues/2046

As i said, not sure if we can get rrun to use travis + containers (which is the recommended and "new" way to run travis): https://docs.travis-ci.com/user/workers/container-based-infrastructure/

buster commented 8 years ago

If you rebase this on the new master it will hopefully pass tests

nightscape commented 8 years ago

Unfortunately, the container-based builds are also based on Ubuntu 12.04 Precise with the same hopelessly outdated GTK. I'm just trying the Trusty beta which is unfortunately not available for containers...

nightscape commented 8 years ago

Wow, this was annoying. I wouldn't have expected Travis to be based on such an old version of Ubuntu. So, back to sudo: required and slow builds :-1: but at least we can use newer GTK versions now :+1: Good to merge from my side.

buster commented 8 years ago

Can we also get rid of the Entry then and just use SearchEntry? :)