search

busterjs / buster

Abandoned - A powerful suite of automated test tools for JavaScript.
http://docs.busterjs.org
Other
448 stars 37 forks source link

Fix for issue #125: Win compat: make bin/buster work on Windows #368

Closed dkl-ppi closed 11 years ago

dkl-ppi commented 11 years ago

Sub-commands for bin/buster are no longer supported.

augustl commented 11 years ago

Hey,

the shelling out from "buster foo" to buster-foo is an intended feature that we don't want to remove. It works fine on *nix, and is borrowed from "git". You can put git-foo on $PATH, and invoke it with "git foo" for convenience.

Since this probably doesn't work on windows (?), I think it's better to either have a separate "cmd" on windows that doesn't have this functionality, or have an if-test in the node script that prints "buster [command] doesn't work on Windows" when the script runs on Windows.

dkl-ppi commented 11 years ago

@augustl, removing that feature is a decision of @cjohansen.

The feature not only makes problems on windows, but also on *nix, for example #220.

augustl commented 11 years ago

Ah, I guess I haven't paid enough attention, I didn't see that discussion. <rant>The Github issue trakcer is where data goes to die.. Unless there's some way of using it that I'm not aware of.</rant>

I agree that it's not really a very useful feature. In many ways it's more confusing than helpful. And if we can't make it work, I guess it's no reason not to remove it.

cjohansen commented 11 years ago

@augustl Sorry, my bad. We discussed it on irc... Anyway, it's a purely cosmetic feature that does nothing but add some overhead (another process) and additionally doesn't work on Windows. It's also highly confusing for local buster installs. So, removing it will make buster more reliable and obvious, which I think is good.

augustl commented 11 years ago

It's also highly confusing for local buster installs

Not that this debate needs a killer arugment, but this is certainly one.