busterjs / buster

Abandoned - A powerful suite of automated test tools for JavaScript.
http://docs.busterjs.org
Other
448 stars 37 forks source link

buster-test exit code is 1 though tests pass #384

Closed olance closed 10 years ago

olance commented 10 years ago

I'll admit it's probably not a very common use case... Imagine a single empty spec:

describe 'MyClass', ->

This is a totally valid spec file (using CoffeeScript for brevity). If it is the only file of my test suite, buster-test will return:

0 tests, 0 assertions, 1 runtime ... OK

However, the tool's exit code value in that case will be: 1

Which makes any tool believe the tests have failed.

Whenever buster-test outputs "OK", I guess the returned exit code should be 0.

dwittner commented 10 years ago

You are right, that doesn't fit together very well. The fix ad479be ensures, that you will get an exit code of 0 for your case.

olance commented 10 years ago

Great, thanks :)