Buster is modifying the global `Error` object (via old JSDOM)

[grncdr]

cat <<EOF | node
console.log(Error.prototype.__proto__);
require('buster');
console.log(Error.prototype.__proto__);
EOF
{}
{ [Function: XPathException] INVALID_EXPRESSION_ERR: 51, TYPE_ERR: 52 }

I haven't dug down to figure out where in JSDOM the bug is, but is it really required for running tests in the 'node' environment??? :-1:

[grncdr]

Some further investigation has turned up https://github.com/tmpvar/jsdom/pull/688 which fixes this bug. However buster-test and buster-syntax are both using quite old versions of jsdom (~0.5.3 and ~0.2.14 respectively).

[dwittner]

JsDom is used by the html reporter, which can also be used for node.js test runs. I will update the version of JsDom for buster-test and buster-syntax.

[dwittner]

@grncdr, i have published new version 0.7.7 of buster-test and 0.4.3 of buster-syntax right now, both with new version ~0.10 of JsDom. Please check if your issue is solved now.

[grncdr]

Yes, looks good to me now. Thanks for the quick response.

-Stephen

On June 6, 2014 at 4:47:21 PM, Daniel Wittner (notifications@github.com) wrote:

@grncdr, i have published new version 0.7.7 of buster-test and 0.4.3 of buster-syntax right now, both with new version ~0.10 of JsDom. Please check if your issue is solved now.

— Reply to this email directly or view it on GitHub.

[dwittner]

You're welcome!