search

busterjs / buster

Abandoned - A powerful suite of automated test tools for JavaScript.
http://docs.busterjs.org
Other
448 stars 37 forks source link

allow more than 3 arguments in handleUncaughtError() #423

Closed dominykas closed 9 years ago

dominykas commented 9 years ago

This is probably a recent change in the browsers - Firefox and Chrome now both have 5 arguments to window.onerror

https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers.onerror

This fixes Uncaught exception: undefined at the start of the test run into an actually readable Uncaught exception: ./index.test.js:1 Uncaught ReferenceError: require is not defined (or whatever the error was)

Part of https://github.com/busterjs/buster/issues/422

dwittner commented 9 years ago

Thank you! Good job! Keep going! ;)