busterjs / buster

Abandoned - A powerful suite of automated test tools for JavaScript.
http://docs.busterjs.org
Other
448 stars 37 forks source link

buster-server says "running" even if address is already in use #432

Closed dwittner closed 9 years ago

dwittner commented 9 years ago

Starting buster-server twice produces the following output for me on my windows machine:

Address already in use. Pick another port with -p/--port to start buster-server
buster-server running on http://localhost:1111

The second message isn't displayed on my linux machine. I don't know whether it is the OS or node.js version which makes the different.

I have seen that we use process.nextTick() in buster-server-cli\lib\server-cli.js. I think using a callback for server.listen instead, would be better and solve this problem.

GCheung55 commented 9 years ago

Please take a look at the PR.

dwittner commented 9 years ago

Fixed in version 0.3.2 of buster-server-cli.