busterjs / grunt-buster

Grunt task for running Buster.JS tests in Node.js or headless in PhantomJS
MIT License
35 stars 14 forks source link

Server isn't stopped in hybrid node+web test runs #3

Closed VoQn closed 11 years ago

VoQn commented 12 years ago

I tried Hybrid testing, but grunt buster did not stop buster-test server after testing.

example buster.js

var config = module.exports;

config['Test Suites'] = {
  rootPath: '../',
  libs: ['lib/my-lib.js'],
  tests: ['test/**/*-test.js']
};

config['Browser Tests'] = {
  extends: 'Test Suites',
  environment: 'browser',
  sources: ['lib/my-lib.js']
};

config['Node Test'] = {
  extends: 'Test Suites',
  environment: 'node'
};

Problem

if user's grunt.js is written like this, grunt watch work unuseful :-(

grunt.initConfig({
  lint: { files: [ 'grunt.js', 'src/*.js', 'test/*-test.js' ] },
  buster: { test: { config: './test/buster.js' } },
  watch: {
    files: [ 'grunt.js', 'test/*.js', 'src/*.js' ],
    tasks: 'lint buster'
  }
});

Is this individual environmental matter? or plugin bug?

thedersen commented 12 years ago

This is a bug in buster, https://github.com/busterjs/buster/issues/239

jodal commented 11 years ago

This bug was fixed in Buster.