Window overlay issue/suggestion

[GoogleCodeExporter]

I glanced through HKWindowManager.m and it appears that you're determining 
whether a Stars 
window is a table or not by checking for the number of hyphens in the title of 
the window, yes?.  Well, when a tournament table is resized to a certain point, 
BS no longer overlays a colored 
window frame.  It also only appears to happen with MTT tables when the blinds 
are fairly large 
(eg $2000/$4000).

Perhaps there is another way of determining if the active window is a table or 
not, in order to be 
able to resize tables to ANY size?  I'm just spitballing here and have no idea 
if this would actually 
work, but why not simply check for a $ symbol at the beginning of the title?  
As far as I'm aware, 
the only Stars window titles that include monetary symbols at the beginning are 
tables..I could of 
course be wrong, though.  Obviously if you made this specific change BS would 
no longer work 
for play money games without adding a bit more code, so testing might get a 
little more 
expensize :).  Just a thought..

FWIW I wouldn't play with such small tables so it would not directly affect me 
during sessions, 
but I'm sure it could affect some users at some point.

Original issue reported on code.google.com by BuckNu...@gmail.com on 2 Feb 2010 at 4:07

[GoogleCodeExporter]

Not sure how to edit, but I just checked that cash game tables do not begin 
with a $ symbol, so my 
suggestion probably wouldn't work.  The only other thing I can think of right 
now is to do a table check by 
looking for a forward slash in the title, indicating the stakes--for cash 
games--or current blind level--for 
tournaments.  I believe this would still allow play money games to work.

Or possibly just checking for the word 'Blinds' (for tournament tables) and 
'USD' or 'EUR' for cash game tables? 
(play money wouldn't work this way)

Either of these ways would seem to work just fine at ANY table size, though I 
haven't tried to punch out any 
code yet as I'm still getting familiar with how you're interacting with 
everything and don't wanna break 
anything :)

Original comment by BuckNu...@gmail.com on 2 Feb 2010 at 4:19

[GoogleCodeExporter]

BuckNut,

I'll take a look at this tomorrow morning when I get to work;  in the mean 
time, feel free to go wild with 
the code. If you're working off the SVN code, the worst you can do is screw it 
up badly enough that you 
need to revert! :)  If you get something more stable working in the meantime, 
let me know. 

Original comment by steven.h...@gmail.com on 2 Feb 2010 at 4:36

[GoogleCodeExporter]

BuckNut,

Hmm, I see what you mean.  Unfortunately, PS is abbreviating the window titles 
as the
window grows smaller, and when the window title is long enough, one or more 
hyphens
just up and disappears.  I put a quick fix in the code for this, but it's a bit
dirty.  Steve, how are you dealing with this in PC?

Original comment by steven.h...@gmail.com on 2 Feb 2010 at 8:11

[GoogleCodeExporter]

I never noticed this problem. I guess a couple of people have reported that the 
HUD 
stopped working late in a tournament, but I never got enough info to 
reproduce...

Original comment by steve.mc...@gmail.com on 2 Feb 2010 at 8:22

[GoogleCodeExporter]

Well, if you come up with a better way of handling it than I am, let me know. 
:-)

Original comment by steven.h...@gmail.com on 2 Feb 2010 at 8:26

[GoogleCodeExporter]

Any problems with the fix so far?

Original comment by steven.h...@gmail.com on 3 Feb 2010 at 6:59

[GoogleCodeExporter]

Original comment by steven.h...@gmail.com on 5 Feb 2010 at 9:52

• Changed state: Fixed