bustle / mobiledoc-kit

A toolkit for building WYSIWYG editors with Mobiledoc
https://bustle.github.io/mobiledoc-kit/demo/
MIT License
1.55k stars 156 forks source link

Typescriptify Phase IV 💃🕺 #742

Closed ZeeJab closed 3 years ago

ZeeJab commented 3 years ago

This PR is Phase 4 of migrating the mobiledoc-kit lib to typescript. The primary focus here was the parsers.

Additionally, while doing this work, I discovered that the legacy image section did not have clone() implemented, which is bug. This bug was not caught previously because there were no tests for it. I fixed the bug, and added a test... however, the test is failing in Safari due to unusual behavior in selection management that differs from Chrome and Firefox.

I'm skipping the test for now, and we can either remove the image section in an upcoming refactor (which was part of the road to 1.0 plan from the beginning) or find a fix for the Safari bug.