search

bustle / mobiledoc-kit

A toolkit for building WYSIWYG editors with Mobiledoc
https://bustle.github.io/mobiledoc-kit/demo/
MIT License
1.55k stars 156 forks source link

v0.12.4 based update for IME bugs #746

Closed tnmt closed 3 years ago

tnmt commented 3 years ago

Hi.

I made PR #745 but there is no appropriate branch to contribute.

Could you cherry-pick 8f05bcf534dd33ee5ecf294bc8d9e4935f9141a8 to 0.12.4 and release in 0.12.5 ?

Thanks.

ZeeJab commented 3 years ago

I prefer not to, but if it's a blocker we can consider it. What is your blocker to upgrading to 0.13.x?

tnmt commented 3 years ago

Thank you for reply and sorry for insufficient information.

I use Ghost CMS https://github.com/TryGhost/Ghost and Ghost uses own TryGhost/mobiledoc-kit based on bustle/mobiledoc-kit. Unfortunately TryGhost/mobiledoc-kit is still based on 0.12.x (you can see in release page). I surmise that TryGhost community have some difficulty with catching up to original 0.13.x changes. There are some old dist path specifications in many Ghost code.

I once planed to patch TryGhost/mobiledoc-kit, but I guess that TryGhost/mobiledoc-kit is not only project which use 0.12.x bustle/mobiledoc-kit, so I suggest this Issue.

This bug (fix in #738) is hard problem for me (and maybe other IME users like #548 TryGhost/mobiledoc-kit#11 TryGhost/Ghost#11460) and I want to fix older 0.12.x version also.

If 0.12.5 will be release, I will discuss with Ghost community for taking in this change. Or should I limit to patch each project which use old mobiledoc-kit ?

ZeeJab commented 3 years ago

Released v0.12.5 with the IME fix backported. Let me know if you run into any trouble.

tnmt commented 3 years ago

Thank you for release v0.12.5 !!