search

bustle / mobiledoc-kit

A toolkit for building WYSIWYG editors with Mobiledoc
https://bustle.github.io/mobiledoc-kit/demo/
MIT License
1.55k stars 150 forks source link

Add additional re-exports #755

Closed RuslanZavacky closed 3 years ago

RuslanZavacky commented 3 years ago

Add exports to allow to build additional use-cases on top of mobiledoc-kit. Left comment https://github.com/bustle/mobiledoc-kit/pull/710#issuecomment-822427552 and realized that it seems to be possible to add more exports.

This 3 exports should cover re-exports here in TryGhost - https://github.com/TryGhost/SDK/blob/main/packages/html-to-mobiledoc/lib/converter.js#L1 and this is something we also use in the similar fashion.

I am open for comments how to better approach this if this is not the way to re-export this internal bits.

ZeeJab commented 3 years ago

Hi! These are not part of the public API, they’re meant for internal use which is why they weren’t exported. But if you need them it seems fine. I can do a release later.

We can also work on making them part of the public API.

RuslanZavacky commented 3 years ago

They help in a way when we want to do Mobiledoc -> HTML and then HTML -> Mobiledoc translation. If they can be part of public API - that would great help (or analogue API, that can be public).

Thank you!

ZeeJab commented 3 years ago

Everything you need should be in the latest release now @RuslanZavacky 👍