search

bustle / mobiledoc-kit

A toolkit for building WYSIWYG editors with Mobiledoc
https://bustle.github.io/mobiledoc-kit/demo/
MIT License
1.55k stars 156 forks source link

Split shortcuts by platform and name them #789

Open lukemelia opened 10 months ago

lukemelia commented 10 months ago

This is a rebase and modernization of @hpohlmeyer's #591.

Our use case is that we need to unregister the default toggleLink commands to replace them with our own more sophisticated link editing UI.

Note that before this PR, both Mac and Windows-style shortcuts worked on both platforms. After this PR, Mac gets standard mac shortcuts (mostly Command + ...) and other platforms get standard Windows shortcuts (mostly Ctrl + ...). I think this is preferable and makes the code clearer. However, if this change is not desirable, I can revise this PR to only add names and not split commands by platform.

lukemelia commented 10 months ago

CI failures are related to sauce labs credentials