bustle / shep

A framework for building JavaScript Applications with AWS API Gateway and Lambda
MIT License
378 stars 27 forks source link

shep config sync messes up code #277

Closed chris-olszewski closed 7 years ago

chris-olszewski commented 7 years ago

It currently publishes a new version based off of whatever latest code is.

chris-olszewski commented 7 years ago

So having builds archived would be very useful here. Otherwise we're going to have to download the code zip and push it up again anytime we want to update an environment variable

chris-olszewski commented 7 years ago

For documentation purposes: this is the culprit anything that calls this i.e. anything that touches the environments is messed up. It publishes the version a version with the code from $LATEST

reconbot commented 7 years ago

Looks like you can specify the alias in the function's arn when you push configs.

https://docs.aws.amazon.com/lambda/latest/dg/API_PublishVersion.html

FunctionArn: The Amazon Resource Name (ARN) assigned to the function. Type: String Pattern: arn:aws:lambda:[a-z]{2}-[a-z]+-\d{1}:\d{12}:function:[a-zA-Z0-9-_]+(:(\$LATEST|[a-zA-Z0-9-_]+))?

chris-olszewski commented 7 years ago

~Are we still going for the "every change to env should be a new version" route?~ Yup, lambda enforces that

reconbot commented 7 years ago

I thought lambda enforced that

On Tue, Jul 11, 2017 at 3:41 PM, Chris Olszewski notifications@github.com wrote:

Are we still going for the "every change to env should be a new version" route?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bustle/shep/issues/277#issuecomment-314550228, or mute the thread https://github.com/notifications/unsubscribe-auth/AABlblbu-lNJ2OZ3M2yZ4-CUKv31UFrQks5sM8_WgaJpZM4OUjj7 .

-- Francis Gulotta Director of Engineering Bustle.com / @bustlelabs

southpolesteve commented 7 years ago

Don't we have to do that? I was under the impressions the versions were immutable

On Tue, Jul 11, 2017 at 3:41 PM, Chris Olszewski notifications@github.com wrote:

Are we still going for the "every change to env should be a new version" route?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bustle/shep/issues/277#issuecomment-314550228, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcxaDiy2U3HiLPurst0ND-Coi9iFaHxks5sM8_XgaJpZM4OUjj7 .

southpolesteve commented 7 years ago

Let the record show gmail says I was first:

screenshot 2017-07-11 15 42 38
reconbot commented 7 years ago

Fixed in 5x beta

chris-olszewski commented 7 years ago

Full fixed in #282