Closed dmabuada closed 2 years ago
Fair warning I think we're going to remove this feature as it doesn't really work.
On Thu, Jul 5, 2018, 2:54 PM Dalia Abuadas notifications@github.com wrote:
Laziness galore, for people who don't want to go into the S3 UI (or via cli) to manually create a bucket.
You can view, comment on, or merge this pull request online at:
https://github.com/bustle/shep/pull/317 Commit Summary
- Create bucket if value exists but bucket doesn't
- Bucket s3 config
File Changes
- M src/util/aws/s3.js https://github.com/bustle/shep/pull/317/files#diff-0 (24)
- M src/util/upload-builds.js https://github.com/bustle/shep/pull/317/files#diff-1 (6)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bustle/shep/pull/317, or mute the thread https://github.com/notifications/unsubscribe-auth/AABlbjyHW-s9XVvxudrMstG8HW8lWeV1ks5uDmDngaJpZM4VEYNO .
@reconbot the s3 push feature in general?
yeah
On Thu, Jul 5, 2018 at 4:51 PM, Dalia Abuadas notifications@github.com wrote:
@reconbot https://github.com/reconbot the s3 push feature in general?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bustle/shep/pull/317#issuecomment-402848784, or mute the thread https://github.com/notifications/unsubscribe-auth/AABlblTCeK9N2379JzWIBkCey86hEFXtks5uDnxggaJpZM4VEYNO .
-- Francis Gulotta VP of Engineering Bustle.com / @bustlelabs
Laziness galore, for people who don't want to go into the S3 UI (or via cli) to manually create a bucket.