bustle / shep

A framework for building JavaScript Applications with AWS API Gateway and Lambda
MIT License
377 stars 27 forks source link

If "bucket" value is set but bucket doesn't exist on S3, create bucket #317

Closed dmabuada closed 2 years ago

dmabuada commented 6 years ago

Laziness galore, for people who don't want to go into the S3 UI (or via cli) to manually create a bucket.

reconbot commented 6 years ago

Fair warning I think we're going to remove this feature as it doesn't really work.

On Thu, Jul 5, 2018, 2:54 PM Dalia Abuadas notifications@github.com wrote:

Laziness galore, for people who don't want to go into the S3 UI (or via cli) to manually create a bucket.

You can view, comment on, or merge this pull request online at:

https://github.com/bustle/shep/pull/317 Commit Summary

  • Create bucket if value exists but bucket doesn't
  • Bucket s3 config

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bustle/shep/pull/317, or mute the thread https://github.com/notifications/unsubscribe-auth/AABlbjyHW-s9XVvxudrMstG8HW8lWeV1ks5uDmDngaJpZM4VEYNO .

dmabuada commented 6 years ago

@reconbot the s3 push feature in general?

reconbot commented 6 years ago

yeah

On Thu, Jul 5, 2018 at 4:51 PM, Dalia Abuadas notifications@github.com wrote:

@reconbot https://github.com/reconbot the s3 push feature in general?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bustle/shep/pull/317#issuecomment-402848784, or mute the thread https://github.com/notifications/unsubscribe-auth/AABlblTCeK9N2379JzWIBkCey86hEFXtks5uDnxggaJpZM4VEYNO .

-- Francis Gulotta VP of Engineering Bustle.com / @bustlelabs