search

busy-beaver-dev / busy-beaver

The Chicago Python Community Engagement Slack bot
https://busybeaverbot.com
MIT License
70 stars 23 forks source link

Improve user experience for uploading logos #319

Closed alysivji closed 4 years ago

alysivji commented 4 years ago

Another part of #295

What does this do

Improve user experience for uploading logo. We are splitting up the forms and showing the current logo (if they have one).

Why are we doing this

Improve user experience

How should this be tested

Wrote end-to-end tests to ensure things work as expected

Migrations

n/a

Dependencies

n/a

Callouts

n/a

codecov-commenter commented 4 years ago

Codecov Report

Merging #319 into feature/display-uploaded-load will increase coverage by 0.14%. The diff coverage is 93.33%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           feature/display-uploaded-load     #319      +/-   ##
=================================================================
+ Coverage                          92.33%   92.48%   +0.14%     
=================================================================
  Files                                 71       71              
  Lines                               2362     2394      +32     
=================================================================
+ Hits                                2181     2214      +33     
+ Misses                               181      180       -1
Impacted Files Coverage Δ
busy_beaver/apps/web/views.py 77.77% <92.85%> (+3.88%) :arrow_up:
busy_beaver/apps/web/forms.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b9cd2e4...3b4c5ad. Read the comment docs.